Re: [PATCH 1/2] dt-bindings: display: Add Solomon SSD1351 OLED controller

[Krzysztof Kozlowski]

> +properties:
> +  compatible:
> +    enum:
> +      - solomon,ssd1351
> +
> +  solomon,width:
> +    default: 128
> +
> +  solomon,height:
> +    default: 128

Drop both - deducible from the compatible.

> +
> +  rotation: true

Either drop or reference panel-common (if this is a panel) or at least
reference that property:
$ref: /schemas/display/panel/panel-common.yaml#/properties/rotation

> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        oled@0 {
> +            compatible = "solomon,ssd1351";
> +            reg = <0x0>;
> +            reset-gpios = <&gpio2 7>;
> +            dc-gpios = <&gpio2 8>;

Use proper defines for GPIO flags

Best regards,
Krzysztof