Re: [PATCH v2 1/8] irqchip/qcom-pdc: restructure version support

[Konrad Dybcio]

On 5/26/26 12:54 PM, Maulik Shah wrote:
> PDC irqchip updates IRQ_ENABLE and IRQ_CFG and for three different
> versions v2.7, v3.0 and v3.2. These registers are organized in H/W
> as below on various SoCs.

[...]

> +static const struct pdc_cfg pdc_cfg_v3_2 = {
> +	.irq_enable = GENMASK(3, 3),

BIT(3)

[...]


> +	pdc->base = ioremap(res.start, res_size);

Can we use devm_ioremap() here?

[...]

>  	if (of_device_is_compatible(node, "qcom,x1e80100-pdc")) {
> -		pdc_prev_base = ioremap(res.start - PDC_DRV_SIZE, IRQ_ENABLE_BANK_MAX);
> -		if (!pdc_prev_base) {
> +		pdc->prev_base = ioremap(res.start - PDC_DRV_SIZE,
> +					 pdc->regs->irq_en_reg + IRQ_ENABLE_BANK_MAX);

likewise

Konrad