Re: [PATCH v5 phy-next 06/16] phy: lynx-28g: generalize protocol converter accessors

[Ioana Ciornei]

On Wed, Jun 10, 2026 at 06:19:42PM +0300, Vladimir Oltean wrote:
> The protocol converters on the 10G Lynx are architecturally similar, but
> different in layout from the 28G Lynx ones.
> 
> Move lynx_pccr_read(), lynx_pccr_write(), lynx_pcvt_read() and
> lynx_pcvt_write() from the 28G Lynx driver to the common module, and
> permit each SerDes driver to provide just its own bits in order to use
> this common API.
> 
> Currently, that just means that the direct calls to
> lynx_28g_get_pcvt_offset() are modified to go through the
> lynx->info->get_pcvt_offset() indirect function call, and similarly,
> lynx_28g_get_pccr() through lynx->info->get_pccr().
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>

Reviewed-by: Ioana Ciornei <ioana.ciornei@xxxxxxx>