Re: [PATCH 3/4] clk: qcom: Add EVA clock controller driver for Glymur SoC

[Konrad Dybcio]

On 5/26/26 7:29 AM, Taniya Das wrote:
> Add the Enhanced Video Analytics (EVA) clock controller driver for
> the Glymur SoC. The EVACC manages the PLL, RCGs, branch clocks, GDSCs
> and resets for the EVA subsystem which handles vision processing
> workloads.
> 
> Signed-off-by: Taniya Das <taniya.das@xxxxxxxxxxxxxxxx>
> ---

[...]

> +enum {
> +	DT_AHB_CLK,
> +	DT_BI_TCXO,
> +	DT_BI_TCXO_AO,

DT_BI_TCXO_AO is unused, will it ever be?

[...]

> +static void clk_glymur_regs_configure(struct device *dev, struct regmap *regmap)
> +{
> +	/* Update CTRL_IN register */

Is there any better comment we could share here?

> +	regmap_update_bits(regmap, 0x9f24, BIT(0), BIT(0));

regmap_set_bits()

otherwise lgtm

Konrad