Re: [PATCH v3 4/4] net: phy: at803x: add RX and TX clock management for IPQ5018 PHY

[George Moussalem]

On 6/11/26 16:52, Andrew Lunn wrote:
>> Is there any prior art wrt enabling/disabling the PHYs (not necessarily
>> clocks specifically, but say power supplies) at runtime?
>> A quick grep only points to this very driver, which gets the regulator
>> during probe, enables it and never turns it off
> 
> Not really. PHYs which care about power do their own power
> management. They can sense the line and know if there is anything
> plugged in the other end, and only then enable parts of the PHY. The
> difference between an active and sleeping 1G PHY should be around 1
> Watt. I don't think you will save too much more by turning off the
> clocks.

in v4, clocks are enabled in probe using devm_clk_get_enabled.
There are currently no users so there will be no backwards compatibility
issues.

Kindly have a look here:
https://lore.kernel.org/all/20260608-ipq5018-gephy-clocks-v4-0-fb2ccd56894b@xxxxxxxxxxx/

> 
> 	Andrew

Thanks,
George