Re: [PATCH v4 1/2] xfs: skip inode inactivation on a shut down mount

[Christoph Hellwig]

On Wed, Jun 10, 2026 at 10:25:38PM +0300, Mikhail Lobanov wrote:
> Hi Christoph,
> 
> > we'll probably want another patch to exit early in xfs_qm_dqdetach for
> > that case
> 
> Before I send that, I went looking for a path that actually reaches it and
> couldn't find one in the current tree - so I wanted to check whether you
> had a specific case in mind or meant it as hardening.
> 
> xfs_qm_dqdetach() only touches the quota subsystem (the final
> xfs_qm_dqrele() puts the dquot back on qi->qi_lru) when a dquot is actually
> attached, and a dquot can only be attached if m_quotainfo was non-NULL at
> attach time.  That leaves two windows:

You're right.  I did rememer review tools comments about this, but
they do look bogus.