Re: [PATCH v2 1/7] dt-bindings: media: qcom: Add Shikra CAMSS compatible

[Bryan O'Donoghue]

On 08/06/2026 21:46, Krzysztof Kozlowski wrote:
> On Mon, Jun 08, 2026 at 07:36:38PM +0530, Nihal Kumar Gupta wrote:
> > Shikra contains the same Camera Subsystem IP as QCM2290. Document the
> > platform-specific compatible string, using qcom,qcm2290-camss as
> > fallback.
> >
> > Unlike QCM2290, Shikra omits the CDM and OPE blocks, requiring only a
> > single IOMMU context bank instead of four.
> >
> > Signed-off-by: Nihal Kumar Gupta <nihal.gupta@xxxxxxxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/media/qcom,qcm2290-camss.yaml    | 16 +++++++++++++---
> >   1 file changed, 13 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml b/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml
> > index 391d0f6f67ef5fdfea31dd3683477561516b1556..4f39eefb4898ebc22117407f26cfb4f41deb111b 100644
> > --- a/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml
> > +++ b/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml
> > @@ -14,8 +14,11 @@ description:
> >   
> >   properties:
> >     compatible:
> > -    const: qcom,qcm2290-camss
> > -
>
> Do not remove blank lines.
>
> > +    oneOf:
> > +      - items:
> > +          - const: qcom,shikra-camss
> > +          - const: qcom,qcm2290-camss
> > +      - const: qcom,qcm2290-camss
> >     reg:
>
> With this fixed:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
>
> Best regards,
> Krzysztof

@Nihal.

If this is the only change you get asked to make, I will just fix this 
up on application for you. There's no need to v3 the series for this.

---
bod