Re: [PATCH] media: amphion: Remove obsolete frame_count check in venc_start_session

[Frank Li]

On Thu, Jun 11, 2026 at 05:17:00PM +0900, Ming Qian wrote:
> The dev_err log warning about no input when starting was originally

nit: dev_err()

> meaningful when min_queued_buffers was set, as it indicated an abnormal
> condition. However, since commit 5633ec763a2a ("media: amphion: Drop
> min_queued_buffers assignment") removed the min_queued_buffers
> assignment, having frame_count == 0 at start is a normal condition.
>
> Remove this misleading log that no longer serves any purpose.
>
> Fixes: 5633ec763a2a ("media: amphion: Drop min_queued_buffers assignment")
> Signed-off-by: Ming Qian <ming.qian@xxxxxxxxxxx>

Reviewed-by: Frank Li <Frank.Li@xxxxxxx>

> ---
> Remove a misleading dev_err log in the encoder start session path that
> became obsolete after the min_queued_buffers removal.
> ---
>  drivers/media/platform/amphion/venc.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/platform/amphion/venc.c b/drivers/media/platform/amphion/venc.c
> index 0b3d58b9f2f7..2ba4ae20f829 100644
> --- a/drivers/media/platform/amphion/venc.c
> +++ b/drivers/media/platform/amphion/venc.c
> @@ -973,8 +973,6 @@ static int venc_start_session(struct vpu_inst *inst, u32 type)
>  	venc->ready_count = 0;
>  	venc->stopped = false;
>  	vpu_process_output_buffer(inst);
> -	if (venc->frame_count == 0)
> -		dev_err(inst->dev, "[%d] there is no input when starting\n", inst->id);
>
>  	return 0;
>  error:
>
> ---
> base-commit: 06cb687a5132fcffe624c0070576ab852ac6b568
> change-id: 20260611-amphion-enc-log-fdf1d7613b5c
>
>