Re: [PATCHv4 15/15] dmaengine: fsldma: fix kernel-doc param names to match function signatures

[Frank Li]

On Wed, Jun 10, 2026 at 08:52:45PM -0700, Rosen Penev wrote:
> Fix kernel-doc warnings where the documented parameter names
> (@chan) no longer match the actual function signatures (@dchan),
> and add the missing @cookie and @txstate parameters to
> fsl_tx_status.
>
> These are pre-existing mismatches that predate the recent
> devm conversion series.
>
> Assisted-by: opencode:big-pickle
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> ---

Can you put this simple fix to first patch? So it can pickup easily if
need pick subset.

Reviewed-by: Frank Li <Frank.Li@xxxxxxx>

Frank
>  drivers/dma/fsldma.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
> index 157db416eaaf..694c1b12bf2b 100644
> --- a/drivers/dma/fsldma.c
> +++ b/drivers/dma/fsldma.c
> @@ -685,7 +685,7 @@ static void fsldma_cleanup_descriptors(struct fsldma_chan *chan)
>
>  /**
>   * fsl_dma_alloc_chan_resources - Allocate resources for DMA channel.
> - * @chan : Freescale DMA channel
> + * @dchan : Freescale DMA channel
>   *
>   * This function will create a dma pool for descriptor allocation.
>   *
> @@ -742,7 +742,7 @@ static void fsldma_free_desc_list_reverse(struct fsldma_chan *chan,
>
>  /**
>   * fsl_dma_free_chan_resources - Free all resources of the channel.
> - * @chan : Freescale DMA channel
> + * @dchan : Freescale DMA channel
>   */
>  static void fsl_dma_free_chan_resources(struct dma_chan *dchan)
>  {
> @@ -878,7 +878,7 @@ static int fsl_dma_device_config(struct dma_chan *dchan,
>
>  /**
>   * fsl_dma_memcpy_issue_pending - Issue the DMA start command
> - * @chan : Freescale DMA channel
> + * @dchan : Freescale DMA channel
>   */
>  static void fsl_dma_memcpy_issue_pending(struct dma_chan *dchan)
>  {
> @@ -891,7 +891,9 @@ static void fsl_dma_memcpy_issue_pending(struct dma_chan *dchan)
>
>  /**
>   * fsl_tx_status - Determine the DMA status
> - * @chan : Freescale DMA channel
> + * @dchan : Freescale DMA channel
> + * @cookie : DMA transaction identifier
> + * @txstate : DMA transaction state
>   */
>  static enum dma_status fsl_tx_status(struct dma_chan *dchan,
>  					dma_cookie_t cookie,
> --
> 2.54.0
>