Re: [for-next v2 2/2] RDMA/ionic: Add RCQ userspace support
From: Jason Gunthorpe
Date: Thu Jun 11 2026 - 14:35:20 EST
On Thu, Jun 11, 2026 at 02:55:43PM +0530, Abhijit Gangurde wrote:
> @@ -2154,7 +2157,7 @@ int ionic_create_qp(struct ib_qp *ibqp, struct ib_qp_init_attr *attr,
> int rc;
>
> if (udata) {
> - rc = ib_copy_validate_udata_in(udata, req, rsvd);
> + rc = ib_copy_validate_udata_in(udata, req, ionic_flags);
^^^^^^^^^
> struct ionic_qdesc {
> @@ -84,6 +85,7 @@ struct ionic_qp_req {
> __u8 rq_cmb;
> __u8 udma_mask;
> __u8 rsvd[3];
> + __u32 ionic_flags;
> };
That is not the right way to use these APIs, this will fail old
rdma-cores that used the smaller struct.
Please check everything you did here.
Please support IB_UVERBS_CORE_SUPPORT_ROBUST_UDATA before changing
anything, and your userspace needs to check it before using extended
functions.
Jason