Re: [PATCH 3/3] iio: dac: ad3530r: Add support for AD3532R/AD3532

[Andy Shevchenko]

On Thu, Jun 11, 2026 at 01:29:53PM +0100, Nuno Sá wrote:
> On Thu, Jun 11, 2026 at 07:04:37AM +0000, Paller, Kim Seer wrote:

...

> > > > static const struct regmap_config ad3530r_regmap_config = {
> > > >  	.reg_bits = 16,
> > > >  	.val_bits = 8,
> > > > -	.max_register = AD3530R_MAX_REG_ADDR,
> > > > +	.max_register = AD3532R_MAX_REG_ADDR,
> > > 
> > > What happens if we read off the end (via debugfs) for the smaller parts?
> > 
> > I tested reading registers at 0x1000 and above on AD3531R it just
> > returns 0xFF and no crash. Should I add a per-chip regmap_config to limit
> > the exposed register space?
> 
> Personally, that would make sense to me.

And strictly speaking it's better in case of extending the driver with some
other features.

-- 
With Best Regards,
Andy Shevchenko