Re: [PATCH v5] arm64: dts: qcom: glymur: add coresight nodes

[Jie Gan]

On 6/11/2026 5:28 PM, Konrad Dybcio wrote:
> On 5/19/26 3:14 PM, Jie Gan wrote:
> > Add CoreSight nodes to enable trace paths like TPDM->ETF/STM->ETF.
> > These devices are part of the AOSS, CDSP, QDSS, PCIe5, TraceNoc and
> > some small subsystems, such as GCC, IPCC, PMU and so on.
> >
> > Delete cti_wpss DT node on Mahua since this device will cause NoC issue
> > on Mahua device.
>
> Another good explanation is that it simply doesn't exist there!
>
> > Signed-off-by: Jie Gan <jie.gan@xxxxxxxxxxxxxxxx>
> > ---
>
> [...]
>
>
> > +	tpdm-cdsp-llm {
>
> Nodes without a unit address should be sorted alphabetically
>
> > +		compatible = "qcom,coresight-static-tpdm";
> > +		qcom,cmb-element-bits = <32>;
>
> Do these other TPDMs not have the "DSB element" as the driver
> calls it?

Depends on the design of the TPDM.

tpdm-cdsp-llm here only supports CMB mode.

There are three types of TPDM:
CMB only
DSB only
support both

> > +
> > +		out-ports {
> > +			port {
> > +				cdsp_llm_tpdm_out: endpoint {
> > +					remote-endpoint = <&cdsp_tpda_in1>;
> > +				};
> > +			};
> > +		};
> > +	};
> > +
> > +	tpdm-cdsp-llm2 {
> > +		compatible = "qcom,coresight-static-tpdm";
> > +		qcom,cmb-element-bits = <32>;
> > +
> > +		out-ports {
> > +			port {
> > +				cdsp_llm2_tpdm_out: endpoint {
> > +					remote-endpoint = <&cdsp_tpda_in2>;
> > +				};
> > +			};
> > +		};
> > +	};
> > +
> > +	tpdm-cdsp-cmsr {
> > +		compatible = "qcom,coresight-static-tpdm";
> > +
> > +		qcom,cmb-element-bits = <32>;
> > +		qcom,dsb-element-bits = <32>;
>
> Some nodes have a \n between compatible and other properties, some don't
> Please unify the style (fwiw I prefer the one with a \n)

I will take care of it in the future.

Thanks,
Jie


> > base-commit: e98d21c170b01ddef366f023bbfcf6b31509fa83
>
> Please rebase, doesn't apply on next-20260610
>
> Konrad