Re: [PATCH] ALSA: usb-audio: qcom: Guard sideband endpoint removal
From: Takashi Iwai
Date: Fri Jun 12 2026 - 05:09:11 EST
On Thu, 11 Jun 2026 15:57:22 +0200,
Cássio Gabriel wrote:
>
> qmi_stop_session() conditionally looks up the cached data and sync
> endpoints, but removes each endpoint unconditionally.
>
> The data endpoint is always present for an active offload stream, while
> the sync endpoint is optional. When no sync endpoint exists, ep still
> refers to the data endpoint and the code attempts to remove that endpoint
> a second time. The current sideband implementation rejects the duplicate
> removal, but the teardown path should not pass an unrelated endpoint for
> an absent sync endpoint.
>
> Only look up and remove an endpoint when its cached pipe exists, check the
> lookup result, and clear the cached pipe after handling it. This matches
> the normal stream-disable path.
>
> Fixes: 326bbc348298 ("ALSA: usb-audio: qcom: Introduce QC USB SND offloading support")
> Signed-off-by: Cássio Gabriel <cassiogabrielcontato@xxxxxxxxx>
Applied to for-next branch now. Thanks.
Takashi