Re: [PATCH v3 6/9] smb: client: move struct tcon_list to cifsglob.h

[Meetakshi Setiya]

Reviewed-by: Meetakshi Setiya <msetiya@xxxxxxxxxxxxx>

On Thu, May 21, 2026 at 7:06 AM <rajasimandalos@xxxxxxxxx> wrote:
>
> From: Rajasi Mandal <rajasimandal@xxxxxxxxxxxxx>
>
> struct tcon_list is a small list-node wrapper that pairs a list_head
> with a cifs_tcon pointer, used to safely iterate tcons under a
> superblock outside tlink_tree_lock.
>
> It is currently file-static in misc.c, used only by
> cifs_close_all_deferred_files_sb().  Move it next to the similar
> struct file_list in cifsglob.h so that other _sb() iteration helpers
> can reuse it instead of redefining the same shape locally.
>
> No functional change.
>
> Signed-off-by: Rajasi Mandal <rajasimandal@xxxxxxxxxxxxx>
> ---
>  fs/smb/client/cifsglob.h | 5 +++++
>  fs/smb/client/misc.c     | 5 -----
>  2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/fs/smb/client/cifsglob.h b/fs/smb/client/cifsglob.h
> index 82e0adc1dabd..2a8b955638e7 100644
> --- a/fs/smb/client/cifsglob.h
> +++ b/fs/smb/client/cifsglob.h
> @@ -1807,6 +1807,11 @@ struct file_list {
>         struct cifsFileInfo *cfile;
>  };
>
> +struct tcon_list {
> +       struct list_head entry;
> +       struct cifs_tcon *tcon;
> +};
> +
>  struct cifs_mount_ctx {
>         struct cifs_sb_info *cifs_sb;
>         struct smb3_fs_context *fs_ctx;
> diff --git a/fs/smb/client/misc.c b/fs/smb/client/misc.c
> index 0c54b9b79a2c..7ef135dc8268 100644
> --- a/fs/smb/client/misc.c
> +++ b/fs/smb/client/misc.c
> @@ -28,11 +28,6 @@
>  #include "fs_context.h"
>  #include "cached_dir.h"
>
> -struct tcon_list {
> -       struct list_head entry;
> -       struct cifs_tcon *tcon;
> -};
> -
>  /* The xid serves as a useful identifier for each incoming vfs request,
>     in a similar way to the mid which is useful to track each sent smb,
>     and CurrentXid can also provide a running counter (although it
> --
> 2.43.0
>