Re: [PATCH] tty: serial: core: fix NULL pointer deref in uart_resume_port()

[Greg Kroah-Hartman]

On Mon, Jun 08, 2026 at 09:52:17AM -0700, Weiming Shi wrote:
> uart_resume_port() looks up the tty device child with device_find_child()
> and passes the result straight to device_may_wakeup(). device_find_child()
> returns NULL when the port has no matching tty device child,

How can that happen in a real system?  Have you triggered this before,
if so, what hardware does it?

> and
> device_may_wakeup() dereferences dev->power.can_wakeup, so a NULL tty_dev
> faults. uart_suspend_port() already guards the same call with
> "tty_dev && device_may_wakeup(tty_dev)"; the resume path does not.
> 
>  Oops: general protection fault, probably for non-canonical address
>  KASAN: null-ptr-deref in range [0x148-0x14f]
>  RIP: 0010:uart_resume_port (pm_wakeup.h:84 serial_core.c:2477)
>   serial_pnp_resume (8250/8250_pnp.c:522)
>   pnp_bus_resume (drivers/pnp/driver.c:234)

Is this a real oops, or a made up one?

> Mirror the NULL guard from uart_suspend_port(). put_device(tty_dev)
> already tolerates a NULL argument, so only the device_may_wakeup() call
> needs the check; the non-NULL path is unchanged.
> 
> Fixes: b3b708fa2780 ("wake up from a serial port")
> Reported-by: Xiang Mei <xmei5@xxxxxxx>

Where was this reported?

Why isn't this cc: stable?  And why hasn't anyone tripped over it in the
past 19 years?

thanks,

greg k-h