Re: [PATCH v2 0/2] ata: Consistently define pci_device_ids using named initializers

[Damien Le Moal]

On 6/12/26 19:58, Niklas Cassel wrote:
> On Fri, Jun 12, 2026 at 04:42:03PM +0900, Damien Le Moal wrote:
>> On 6/12/26 16:35, Uwe Kleine-König (The Capable Hub) wrote:
>>> Hello,
>>>
>>> (implicit) v1 of this series can be found at
>>> https://lore.kernel.org/linux-ide/20260430170612.510869-2-u.kleine-koenig@xxxxxxxxxxxx
>>>
>>> Damien asked to rework the patch adding more line breaks to make the
>>> resulting lines shorter. I didn't rewrap all arrays, only those that
>>> appeared too long to me; the longest line I kept is:
>>>
>>> +	{ PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP61_SATA3), .driver_data = GENERIC },
>>>
>>> which is short enough to not trigger a checkpatch warning.
>>
>> Yeah. But we tend to stick with the old 80-char max lines.
>> But no big deal as this was already a long line anyway.
>> That said, it is a chance to rewrap that too. If you are willing to send a v3,
>> we'll take it :)
>>
>> Nevertheless, overall, very nice cleanup. Thanks for doing it.
>>
>> For the series:
>>
>> Reviewed-by: Damien Le Moal <dlemoal@xxxxxxx>
> 
> This email does not appear valid according to internal company (wdc.com)
> address book.

Arg. I did it again. I keep mixing up my email addresses :)
Sorry about that.

> 
> I will replace it with:
> Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx>
> 
> when applying.

Thanks.

> 
> 
> Kind regards,
> Niklas


-- 
Damien Le Moal
Western Digital Research