Re: [PATCH v2 09/22] mm/page_alloc: don't overload migratetype in find_suitable_fallback()
From: Brendan Jackman
Date: Fri Jun 12 2026 - 10:45:25 EST
On Fri Jun 12, 2026 at 1:24 PM UTC, Pankaj Gupta wrote:
>
>> This function currently returns a signed integer that encodes status
>> in-band, as negative numbers, along with a migratetype.
>>
>> This function is about to be updated to a mode where this in-band
>> signaling no longer makes sense. Therefore, switch to a more
>> explicit/verbose style that encodes the status and migratetype
>> separately.
>>
>> In the spirit of making things more explicit, also create an enum to
>> avoid using magic integer literals with special meanings. This enables
>> documenting the values at their definition instead of in one of the
>> callers.
>>
>> Signed-off-by: Brendan Jackman <jackmanb@xxxxxxxxxx>
>
> Seems independent patch with no functional change.
>
> Reviewed-by: Pankaj Gupta <pankaj.gupta@xxxxxxx>
Thanks Pankaj - also BTW this and some other patches were already split
out into a separate series and they are now in mm-unstable:
https://lore.kernel.org/all/20260503-x86-init-cleanup-v2-0-bb690bd2477c@xxxxxxxxxx/