Re: [PATCH 2/3] dt-bindings: iio: magnetometer: add QST QMC5883L Sensor

[Jonathan Cameron]

On Fri, 12 Jun 2026 18:45:26 +0600
Siratul Islam <email@xxxxxxxx> wrote:

> Add devicetree binding for the QST QMC5883L 3-Axis Magnetic Sensor
> connected via i2c.
> Interrupt not implemented in driver but kept in the binding for future
> addition.
No need to mention that
> Used enum so that more driver could use this binding

More devices perhaps rather than drivers (binding has nothing
directly to do with drivers).

> 
> Signed-off-by: Siratul Islam <email@xxxxxxxx>
> ---
>  .../iio/magnetometer/qstcorp,qmc5883l.yaml    | 48 +++++++++++++++++++
>  MAINTAINERS                                   |  6 +++
>  2 files changed, 54 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/magnetometer/qstcorp,qmc5883l.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/magnetometer/qstcorp,qmc5883l.yaml b/Documentation/devicetree/bindings/iio/magnetometer/qstcorp,qmc5883l.yaml
> new file mode 100644
> index 000000000000..238cc7e22b89
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/magnetometer/qstcorp,qmc5883l.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/magnetometer/qstcorp,qmc5883l.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: QST QMC5883L 3-Axis Magnetic Sensor
> +
> +maintainers:
> +  - Siratul Islam <email@xxxxxxxx>
It is a bit unusual to have to description section.  Maybe
just have a link to a datasheet if there is someone that seems
reasonable stable to link to.

> +
> +properties:
> +  compatible:

The rest looks good to  me.

Thanks,

Jonathan