Re: [PATCH 0/2] platform/x86: msi-wmi: Fix unknown wmi event messages on MSI Claw models

[Armin Wolf]

Am 12.06.26 um 00:39 schrieb Derek J. Clark:

> MSI Claw devices produce WMI events through the MSI WMI hotkeys GUID for
> some of their buttons. When pressed, these cause spam in the kernel. The
> Claws use a GUID already supported by msi-wmi, but use an
> ACPI_TYPE_BUFFER instead of an ACPI_TYPE_INTEGER.
>
> Patch 1 reformats msi_wmi_notify() to reduce nesting by using early
> returns and a switch case in preparation for handling this new data
> type.
>
> Patch 2 adds known MSI Claw event keycodes to the keymap and support for
> ACPI_TYPE_BUFFER.

Would it be possible to turn this driver into a proper WMI driver using
.notify_new()? This would solve the whole ACPI type problem.

Thanks,
Armin Wolf

> Signed-off-by: Derek J. Clark <derekjohn.clark@xxxxxxxxx>
>
> Derek J. Clark (2):
>    platform/x86: msi-wmi: Reformat msi_wmi_notify()
>    platform/x86: msi-wmi: Add MSI Claw M-Center keys
>
>   drivers/platform/x86/msi-wmi.c | 92 ++++++++++++++++++++++------------
>   1 file changed, 60 insertions(+), 32 deletions(-)