Re: [PATCH v1 1/2] dt-bindings: spi: snps,dw-apb-ssi: Add support for snps,dwc-ssi-2.00a

[Conor Dooley]

On Fri, Jun 12, 2026 at 05:58:55AM -0700, Changhuang Liang wrote:
> Add a new compatible string "snps,dwc-ssi-2.00a" for the Synopsys
> DesignWare SSI controller version 2.00a.

Two things. Firstly, driver patch suggests a fallback to 1.01a is
possible. Why haven't you added one?
Secondly, I am going to expect that when your starfive user for this
appears in my inbox that it has a device-specific compatible, so you may
as well add that now.

pw-bot: changes-requested

Cheers,
Conor.

> 
> Signed-off-by: Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> index 8ebebcebca16..fb74243d4bdf 100644
> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> @@ -41,6 +41,7 @@ properties:
>          enum:
>            - snps,dw-apb-ssi
>            - snps,dwc-ssi-1.01a
> +          - snps,dwc-ssi-2.00a
>        - description: Microchip Sparx5 SoC SPI Controller
>          const: microchip,sparx5-spi
>        - description: Amazon Alpine SPI Controller
> -- 
> 2.25.1
>

Attachment: signature.asc
Description: PGP signature