Re: [PATCH v3 7/8] media: platform: neoisp: Add debugfs support

[Frank Li]

On Fri, Jun 12, 2026 at 03:20:38PM +0200, Antoine Bouyer wrote:
> Add debugfs entries to dump ISP registers, and some internal memory
> regions used to store Vignetting, DRC global and DRC local coefficients.
>
> Debug mode is activated with the `enable_debugfs` module's parameter, to
> avoid runtime suspend which blocks register access when IP is not active,
> so we can capture an ISP snapshot after a frame is decoded.

Look like you needn't this option, see below implementaiton. If you correct
set regset->dev, it will call pm_runtime_get_sync() for you

static int debugfs_regset32_show(struct seq_file *s, void *data)
{
	struct debugfs_regset32 *regset = s->private;

	if (regset->dev)
		pm_runtime_get_sync(regset->dev);

	debugfs_print_regs32(s, regset->regs, regset->nregs, regset->base, "");

	if (regset->dev)
		pm_runtime_put(regset->dev);

	return 0;
}

Frank