Re: [PATCH v3 2/8] media: v4l2-ctrls: Add user control base for NXP neoisp controls

[Frank Li]

On Fri, Jun 12, 2026 at 03:20:33PM +0200, Antoine Bouyer wrote:
> [You don't often get email from antoine.bouyer@xxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> Add a control base for the NXP neoisp driver controls, and reserve up to
> 16 controls.
>
> Signed-off-by: Antoine Bouyer <antoine.bouyer@xxxxxxx>
> ---
>  include/uapi/linux/v4l2-controls.h | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h
> index affec0ab4781..1c44229d349d 100644
> --- a/include/uapi/linux/v4l2-controls.h
> +++ b/include/uapi/linux/v4l2-controls.h
> @@ -234,6 +234,12 @@ enum v4l2_colorfx {
>   */
>  #define V4L2_CID_USER_MALI_C55_BASE            (V4L2_CID_USER_BASE + 0x1230)
>
> +/*
> + * The base for NEOISP driver controls.
> + * We reserve 16 controls for this driver.

Generally, don't use "we" \ "you", just

	Reserve 16 controls for NXP NeoISP

Frank

> + */
> +#define V4L2_CID_USER_NEOISP_BASE              (V4L2_CID_USER_BASE + 0x1240)
> +
>  /* MPEG-class control IDs */
>  /* The MPEG controls are applicable to all codec controls
>   * and the 'MPEG' part of the define is historical */
> --
> 2.53.0
>
>