Re: [PATCH net] net: bcmgenet: Use weighted round-robin TX DMA arbitration

[Justin Chen]

On 6/12/26 12:37 AM, Nicolai Buchwitz wrote:
> On 11.6.2026 19:27, Justin Chen wrote:
>
> > [...]
>
> > > AFAIK the existing queue mechanism dates back to the STB QoS use 
> > > cases Florian
> > > had in mind when he wrote the driver, so let's hear what he has to 
> > > say on this.
> > >
> > > The change itself looks correct to me. My concern is the targeting. This
> > > flips the default policy for every GENET user rather than fixing a 
> > > specific
> > > defect, and Justin's series already called the persistent timeouts a 
> > > design
> > > issue rather than a bug.
> > >
> > > So isn't this more net-next material than net with a broad Fixes: tag?
> > > Please also add to the commit message that it drops the existing 
> > > priority
> > > handling for rings 1-4.
> >
> > I'm ok with these changes. Internally we no longer require priority 
> > queues. It is a legacy use case we no longer have. My idea was to 
> > remove the queues entirely and have one big queue. But I figured I 
> > would wait for Nicolai's XDP changes so we do not need to remove and 
> > re-add queues for XDP. This could be a stop-gap solution until that is 
> > done.
>
> Thanks Justin. IMHO XDP could benefit from a queue-refactoring prep. It 
> gets simpler on top of a single queue, and dropping q1-4 frees up a 
> bunch of BDs for the XDP ring instead of the 32 it has atm.
>
> Happy to take it on, or leave it to you :)

I am not going to say no to less work! Please do.

Thanks,
Justin

> > [...]
>
> Thanks
> Nicolai