Re: [PATCH v2 1/3] misc: lis3lv02d: set default click detection thresholds
From: Jonathan Cameron
Date: Fri Jun 12 2026 - 13:36:17 EST
On Fri, 12 Jun 2026 16:21:56 +0200
Linus Walleij <linusw@xxxxxxxxxx> wrote:
> On Thu, Jun 11, 2026 at 5:41 PM Md Shofiqul Islam <shofiqtest@xxxxxxxxx> wrote:
>
> > Several upstream board DTS files use st,click-thresh-x/y/z (the name
> > documented in the old lis302.txt binding), but the driver reads
> > st,click-threshold-x/y/z. As a result those boards have had click
> > detection silently broken since the DT properties were added.
> >
> > Set a default threshold of 10 for all three axes immediately after
> > the platform data allocation so those boards get working click
> > detection without requiring a DT change.
> >
> > The DT reads for st,click-threshold-x/y/z are unchanged so boards
> > using the correct name can still override the default.
> >
> > Fixes: 6a7740c7f5b2 ("lis3lv02d: add device-tree support")
> >
No blank line here. Tags must always be in one block with no lines
in between them.
> > Signed-off-by: Md Shofiqul Islam <shofiqtest@xxxxxxxxx>
>
> Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>
>
> Yours,
> Linus Walleij