Re: [PATCH v3 2/9] vfio/pci: Add a helper to look up PFNs for DMABUFs
From: Alex Williamson
Date: Fri Jun 12 2026 - 13:38:46 EST
On Thu, 11 Jun 2026 20:30:32 +0000
Pranjal Shrivastava <praan@xxxxxxxxxx> wrote:
> On Wed, Jun 10, 2026 at 04:43:16PM +0100, Matt Evans wrote:
> > + /*
> > + * If we get here, the address fell outside of the span
> > + * represented by the (concatenated) ranges. Setup of a
>
> Nit: double space before "Setup" and "But" below.
Some of us old school'ers consider this proper writing style ;)
Alex
> > + * mapping must ensure that the VMA is <= the total size of
> > + * the ranges, so this should never happen. But, if it does,
> > + * force SIGBUS for the access and warn.
> > + */
> > + WARN_ONCE(1, "No range for addr 0x%lx, order %d: VMA 0x%lx-0x%lx pgoff 0x%lx, %u ranges, size 0x%zx\n",
> > + address, order, vma->vm_start, vma->vm_end, vma->vm_pgoff,
> > + priv->nr_ranges, priv->size);
> > +
> > + return -EFAULT;