Re: [PATCH v2] ALSA: hda/realtek: Enable micmute LED on HP EliteBook 6 G1a

[Denis Batishchev]

Hi Geraldo,

Sorry about wrong email threading. That's first time I'm sending patch to kernel.

My laptop's SKUs is AD3Q9ET#UUG.
It's HP Elitebook G1A 14" too but with a bit different audio chip as I understand.
And quirk is indeed copy-pasted but with different device id.
I can change quirk description string to reflect my laptop version.

Best regards,
Denis B.

On Tue, 2026-06-09 at 11:15 -0300, Geraldo Nascimento wrote:
> Hi Denis,
> 
> On Tue, Jun 09, 2026 at 03:56:07PM +0200, Denis Batishchev wrote:
> > The HP EliteBook 6 G1a (SSID 103c:8e0d) uses a Realtek ALC236 codec.
> > Without a quirk no fixup is selected and the mic-mute LED stays off.
> > It needs the same ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk as the
> > already-supported 14" variant (SSID 103c:8dfb), so add it.
> 
> What is your exact variant of this hardware? Also please refrain from
> sending V2 in response to V1: it makes patches harder to track.
> 
> > 
> > Signed-off-by: Denis Batishchev <ii343hbka@xxxxxxxxx>
> > Cc: <stable@xxxxxxxxxxxxxxx>
> > ---
> > v2: reword commit message as was required by Takashi Iwai
> > 
> >  sound/hda/codecs/realtek/alc269.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> > index 78a865709635..8eebf91595d3 100644
> > --- a/sound/hda/codecs/realtek/alc269.c
> > +++ b/sound/hda/codecs/realtek/alc269.c
> > @@ -7274,6 +7274,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
> >  	SND_PCI_QUIRK(0x103c, 0x8df1, "HP EliteBook 630 G12", ALC236_FIXUP_HP_GPIO_LED),
> >  	SND_PCI_QUIRK(0x103c, 0x8df7, "HP Z66 G6", ALC236_FIXUP_HP_GPIO_LED),
> >  	SND_PCI_QUIRK(0x103c, 0x8dfb, "HP EliteBook 6 G1a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> > +	SND_PCI_QUIRK(0x103c, 0x8e0d, "HP EliteBook 6 G1a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> 
> The description string of the quirk seems copy-pasted. Are you sure
> you have the 14" variant?
> 
> Thanks,
> Geraldo Nascimento
> 
> >  	SND_PCI_QUIRK(0x103c, 0x8dfc, "HP EliteBook 645 G12", ALC236_FIXUP_HP_GPIO_LED),
> >  	SND_PCI_QUIRK(0x103c, 0x8dfd, "HP EliteBook 6 G1a 16", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> >  	SND_PCI_QUIRK(0x103c, 0x8dfe, "HP EliteBook 665 G12", ALC236_FIXUP_HP_GPIO_LED),
> > -- 
> > 2.53.0
> > 
> >