Re: [PATCH 2/3] dt-bindings: iio: magnetometer: add QST QMC5883L Sensor

From: Jonathan Cameron

Date: Sat Jun 13 2026 - 07:18:35 EST


On Sat, 13 Jun 2026 14:57:42 +0600
Sirat <email@xxxxxxxx> wrote:

> On Fri, Jun 12, 2026 at 10:30 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> >
> > On Fri, 12 Jun 2026 18:45:26 +0600
> > Siratul Islam <email@xxxxxxxx> wrote:
> >
> > > Add devicetree binding for the QST QMC5883L 3-Axis Magnetic Sensor
> > > connected via i2c.
> > > Interrupt not implemented in driver but kept in the binding for future
> > > addition.
> > No need to mention that
> Got it. In the past I was advised to mention certain choices in the
> commit message. I am still looking for the balance.

Sure. Generally dt-bindings should never mention the driver.
Despite being in the kernel tree they are not tightly coupled with
the drivers and indeed are pulled into other projects.

Jonathan

> >
> > The rest looks good to me.
> >
> > Thanks,
> >
> > Jonathan
> >
> Thanks
> Sirat