Re: [PATCH] cpufreq: powernow-k6: replace symbolic permissions with octal

[Zhongqiu Han]

On 6/13/2026 7:16 AM, Jack Lee wrote:
> Symbolic permissions S_IRUGO are deprecated in favor of octal
> permissions. Replace S_IRUGO with 0444.


Hi Jack,

Thanks for the patch, the change itself looks reasonable.

However, I'm not sure whether this cleanup alone is compelling enough
for merge.

It might be worth clarifying the commit message, though — as far as I
know, S_IRUGO is not formally deprecated, but rather not preferred,
with octal permissions generally recommended instead (see
Documentation/dev-tools/checkpatch.rst[1]). Using wording closer to
that might be more precise.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/tree/Documentation/dev-tools/checkpatch.rst#n1060


> Signed-off-by: Jack Lee <skunkolee@xxxxxxxxx>
> ---
>   drivers/cpufreq/powernow-k6.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/powernow-k6.c b/drivers/cpufreq/powernow-k6.c
> index 99d2244e03b0..764907b04c04 100644
> --- a/drivers/cpufreq/powernow-k6.c
> +++ b/drivers/cpufreq/powernow-k6.c
> @@ -29,10 +29,10 @@ static unsigned int                     max_multiplier;
>   static unsigned int			param_busfreq = 0;
>   static unsigned int			param_max_multiplier = 0;
>   
> -module_param_named(max_multiplier, param_max_multiplier, uint, S_IRUGO);
> +module_param_named(max_multiplier, param_max_multiplier, uint, 0444);
>   MODULE_PARM_DESC(max_multiplier, "Maximum multiplier (allowed values: 20 30 35 40 45 50 55 60)");
>   
> -module_param_named(bus_frequency, param_busfreq, uint, S_IRUGO);
> +module_param_named(bus_frequency, param_busfreq, uint, 0444);
>   MODULE_PARM_DESC(bus_frequency, "Bus frequency in kHz");
>   
>   /* Clock ratio multiplied by 10 - see table 27 in AMD#23446 */


--
Thx and BRs,
Zhongqiu Han