Re: [PATCH net-next] virtio-net: support xsk wake up

From: Jakub Kicinski

Date: Sat Jun 13 2026 - 17:44:57 EST


On Wed, 10 Jun 2026 16:16:48 +0800 Menglong Dong wrote:
> + /* If both rq->vq and fill ring are empty, and then the user submit
> + * all the chunks to the fill ring and check the wake up flag
> + * after xsk_buff_alloc_batch() and before xsk_set_rx_need_wakeup(),
> + * we will lose the chance to wake up the rx napi, so we have to
> + * set the need_wakeup flag here.
> + */

TBH all the comments you're adding are harder to understand than the
code itself ;( Please try to phrase them better or just remove them.