Re: [RFC PATCH 10/15] x86/tdx: Move and rename Quote request structure
From: Peter Fang
Date: Sun Jun 14 2026 - 07:50:30 EST
On Thu, Jun 11, 2026 at 08:16:37PM +0300, Adrian Hunter wrote:
> > -static int wait_for_quote_completion(struct tdx_quote_buf *quote_buf, u32 timeout)
> > +static int wait_for_quote_completion(struct tdx_quote_req *quote_buf, u32 timeout)
>
> Seems inconsistent to rename the struct but not the variable names
Good catch, I'll fix that.
>
> > {
> > int i = 0;
>
> Please note, the timeout condition in wait_for_quote_completion() is
> broken, in that the final value of i is timeout + 1 not timeout.
> Since you are in the same area, that needs fixing that too.
Thanks for catching that. This needs to be fixed. We can submit a
separate guest-only patch.
>