Re: [PATCH bpf-next v2] bpf: Fix unaligned interpreter panic on JIT fallback path
From: Leon Hwang
Date: Sun Jun 14 2026 - 22:16:38 EST
On 15/6/26 10:05, Tiezhu Yang wrote:
> On 2026/6/15 上午9:49, Leon Hwang wrote:
>> On 15/6/26 09:23, Tiezhu Yang wrote:
[...]
>>
>> I think bpf_fixup_inline_helpers() is not accurate, since it is to fix
>> those non-inline helpers here. bpf_fixup_non_inline_helpers() is a
>> candidate. However, a shorter name is preferred.
>
> I see your point. Indeed, we are fixing up the helpers that ultimately
> failed to be inlined on the fallback path.
>
> How about shortening it to fixup_fallback_helpers()? Since it is a
> static function, we can safely drop the bpf_ prefix to keep it concise,
> clean, and accurate.If that looks good to you, I will use this name and
> remove the redundant check in the next version.
>
bpf_fixup_fallback_helpers() or fixup_fallback_helpers() works for me.
Thanks,
Leon