Re: [PATCH 2/2] pinctrl: qcom: Add the tlmm driver for Maili platform
From: Jingyi Wang
Date: Sun Jun 14 2026 - 22:35:14 EST
On 6/10/2026 4:08 PM, Sneh Mankad wrote:
<...>
On 22-May-26 1:12 PM, Jingyi Wang wrote:
Add support for Maili TLMM configuration and control via the pinctrl
framework.
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
Signed-off-by: Jingyi Wang <jingyi.wang@xxxxxxxxxxxxxxxx>
---
drivers/pinctrl/qcom/Kconfig.msm | 10 +
drivers/pinctrl/qcom/Makefile | 1 +
drivers/pinctrl/qcom/pinctrl-maili.c | 1630 ++++++++++++++++++++++++++++++++++
3 files changed, 1641 insertions(+)
Can you please move "MODULE_DEVICE_TABLE(of, maili_tlmm_of_match);" to immediately follow
the maili_tlmm_of_match[] array definition, grouping the array definition with its associated alias declaration?
Please refer [1].
[1] https://lore.kernel.org/linux-arm-msm/20260505093444.61336-2-krzysztof.kozlowski@xxxxxxxxxxxxxxxx/
Thanks,
Sneh
Will update.
Thanks,
Jingyi