Re: [PATCH V5 6/9] dax/fsdev: fail probe on invalid pgmap offset

[John Groves]

On 26/06/11 08:09PM, Gupta, Pankaj wrote:
> 
> > From: John Groves <John@xxxxxxxxxx>
> > 
> > Convert the WARN_ON to a fatal error when pgmap_phys > phys. This
> > condition means the remapped region starts after the device's data
> > region, which is an impossible state. Previously the probe continued
> > with data_offset=0, leaving virt_addr silently misaligned. Now probe
> > returns -EINVAL with a diagnostic message.
> > 
> > Fixes: 759455848df0b ("dax: Save the kva from memremap")
> > 
> > Reviewed-by: Dave Jiang <dave.jiang@xxxxxxxxx>
> > Reviewed-by: Alison Schofield <alison.schofield@xxxxxxxxx>
> > Signed-off-by: John Groves <john@xxxxxxxxxx>
> 
> Reviewed-by: Pankaj Gupta <pankaj.gupta@xxxxxxx>

Thank you!
John

<snip>