Re: [PATCH v2 1/2] media: atomisp: fix memory leak in atomisp_pci_probe()

[Andy Shevchenko]

On Mon, Jun 15, 2026 at 08:35:15PM +0800, Dawei Feng wrote:
> On Mon, Jun 15, 2026 at 02:11:12PM +0300, Andy Shevchenko wrote:
> >> Fixes: 9d4fa1a16b28 ("media: atomisp: cleanup directory hierarchy")
> >> Signed-off-by: Zilin Guan <zilin@xxxxxxxxxx>
> >> Signed-off-by: Dawei Feng <dawei.feng@xxxxxxxxxx>
> >
> >This SoB chain is wrong. Who is Zilin and why is he here?
> 
> Zilin is the discoverer of this bug. We are in the same research group,
> and he actively participated in reviewing this patch. 

> To better align with the kernel submission guidelines, I will add a
> "Co-developed-by:" tag in the v3 patch for Zilin to properly reflect his
> contributions. Would this be acceptable?

But did he _develop_ any parts of this patch? Otherwise Reported-by is more
suitable.

> >These last two paragraphs do not suit the commit message. Please, drop them
> >here and better to describe all this in the cover letter (if not yet).
> 
> As Dan mentioned, I included those paragraphs following the exapmle in
> researcher-guidelines[1].

Yes, and I still insist to move them to the cover letter. In any case those are
not present in the second patch anyway, moving that to cover letter covers the
entire series (and I believe you tested the entire series, didn't you?).

> [1] https://docs.kernel.org/process/researcher-guidelines.html

-- 
With Best Regards,
Andy Shevchenko