Re: [PATCH v6 05/12] PCI: liveupdate: Keep bus numbers constant during Live Update

[David Matlack]

On 2026-06-14 01:57 PM, Pasha Tatashin wrote:
> On Fri, 22 May 2026 20:24:03 +0000, David Matlack <dmatlack@xxxxxxxxxx> wrote:
> > diff --git a/drivers/pci/liveupdate.c b/drivers/pci/liveupdate.c
> > index 4f2ec6ffdd16..2421bc218916 100644
> > --- a/drivers/pci/liveupdate.c
> > +++ b/drivers/pci/liveupdate.c
> > @@ -103,7 +118,7 @@
> >  /**
> >   * struct pci_liveupdate_global - Global state for PCI Live Update support
> >   * @rwsem: Reader/writer semaphore used to protect the incoming and outgoing
> > - *         FLBs, and the references to them in struct pci_dev.
> > + *         FLBs and references to them in struct pci_dev.
> 
> This change does not belong to this patch.

Yes, will fix.

> 
> > @@ -396,6 +411,72 @@ static void pci_liveupdate_flb_put_incoming(void)
> >  	liveupdate_flb_put_incoming(&pci_liveupdate_flb);
> >  }
> >  
> > +bool pci_liveupdate_scan_bridge_begin(struct pci_bus *bus, struct pci_dev *dev,
> > +				      int pass)
> 
> This function requires a header comment; it is public and not self-descriptive.

It is private to the PCI core, but I can still add a comment in v7.

> 
> -- 
> Pasha Tatashin <pasha.tatashin@xxxxxxxxxx>