Re: [RFC PATCH v6 00/25] Hierarchical Constant Bandwidth Server

[Tejun Heo]

Hello,

Looks great. Two things:

1. cpu.rt.internal doesn't follow the naming convention. The file is the
   cgroup's own budget (cpu.rt.max minus its children), so
   cpu.rt.max.effective.local fits better: .effective like
   cpuset.cpus.effective, .local like memory.events.local.

2. root's cpu.rt.max: sched_rt_runtime_us already caps total DL/RT
   bandwidth and rt-cgroups admit against the same pool, so what does
   reserving the cgroup share separately at root add? It's also a writable
   control on root, which we otherwise keep off root.

Thanks.

--
tejun