Re: [PATCH v1] soc: qcom: apr: Drop unused apr_device_id

From: Dmitry Baryshkov

Date: Mon Jun 15 2026 - 20:53:15 EST


On Mon, Jun 15, 2026 at 12:04:28PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> apr_device_id was introduced in commit 6adba21eb434 ("soc: qcom: Add APR
> bus driver") in 2018, and since then not a single driver made use of it.
>
> So drop the unused id_table pointer from struct apr_driver and move
> APR_NAME_SIZE to the apr header which still has a usage of it.
>
> Note that with the id_table being NULL apr_device_match() degrades to just
> of_driver_match_device(), so replace this callback accordingly.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>
> ---
> drivers/soc/qcom/apr.c | 25 +------------------------
> include/linux/mod_devicetable.h | 11 -----------
> include/linux/soc/qcom/apr.h | 4 ++--
> 3 files changed, 3 insertions(+), 37 deletions(-)
>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>


--
With best wishes
Dmitry