Re: [PATCH v4 19/30] KVM: x86/pmu: Move "struct kvm_x86_pmu_event_filter" definition to pmu.c

[Binbin Wu]

On 6/13/2026 8:03 AM, Sean Christopherson wrote:
> Move the definition of "struct kvm_x86_pmu_event_filter" to pmu.c, as the
> as the details of the filters are very much implementation details that can
   ^
duplicated "as the"


> and should be buried in pmu.c.  While the _existence_ of filters is public
> knowledge, almost by definition, the contents don't need to be exposed
> outside of the PMU code as the filter data is provided by userspace, i.e.
> it pretty much has to be dynamically allocated, and thus never should be
> fully embedded in a globally visible structure.
> 
> No functional change intended
> 
> Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>

Reviewed-by: Binbin Wu <binbin.wu@xxxxxxxxxxxxxxx>