Re: [PATCH 1/4] mm/compaction: stop recording free page order in page->private

[David Hildenbrand (Arm)]

On 6/30/26 03:37, Zi Yan wrote:
> On Mon Jun 29, 2026 at 9:32 PM EDT, Baolin Wang wrote:
>>
>>
>> On 6/29/26 10:56 AM, Zi Yan wrote:
>>> Commit 733aea0b3a7bb ("mm/compaction: add support for >0 order folio
>>> memory compaction.") stores isolated free pages in an array indexed by free
>>> page orders, it is no longer needed to store the order in each page's
>>> ->private field. And there is no code using the stored order. Stop doing
>>> that.
>>>
>>> It also prepares for an upcoming change that ensures subpage->private is
>>
>> I noticed that people tend to avoid using the term "subpage" now, though 
>> I understand what you mean by it here. :)
>>
>> [1] https://lore.kernel.org/all/20260623125723.2503832-1-dev.jain@xxxxxxx/
> 
> Thanks. I was confused which to use subpage or tail page. Now I know
> tail page is the way to go.

Agreed, and agreed that the large comment is not required here.

Reviewed-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>

-- 
Cheers,

David