Re: [PATCH v3] media: atomisp: fix block comment formatting style

[Bohdan Derkach]

Hi Andy,

Thank you for the review.

You are completely right about the indentation and line wraps. Dan
Carpenter also pointed this out to me yesterday, and I have already
prepared a v4 that fixes all of these issues perfectly. I am strictly
following the rule to wait a full 24 hours between sending versions,
so I will send v4 later today.

Regarding your question about whether this is the only issue in the driver:
I understand that sending a patch for a single block comment in a 100k
LoC driver is a very small contribution. Since this is my very first
patch to the Linux kernel, my main goal was to learn the correct
workflow (git send-email, formatting versions, acting on feedback)
before sending larger patch series.

Once this v4 is accepted and I am confident that my setup is correct,
my next step is to grep through the rest of atomisp to fix similar
block comments and submit them as a proper patch series.

Thank you for your patience and for guiding a newcomer!

Regards,
Bohdan


On Wed, Jul 1, 2026 at 11:42 AM Bohdan Derkach <bohdandmarcus@xxxxxxxxx> wrote:
>
> Hi Andy,
>
> Thank you for the review.
>
> You are completely right about the indentation and line wraps. Dan Carpenter also pointed this out to me yesterday, and I have already prepared a v4 that fixes all of these issues perfectly. I am strictly following the rule to wait a full 24 hours between sending versions, so I will send v4 later today.
>
> Regarding your question about whether this is the only issue in the driver:
> I understand that sending a patch for a single block comment in a 100k LoC driver is a very small contribution. Since this is my very first patch to the Linux kernel, my main goal was to learn the correct workflow (git send-email, formatting versions, acting on feedback) before sending larger patch series.
>
> Once this v4 is accepted and I am confident that my setup is correct, my next step is to grep through the rest of atomisp to fix similar block comments and submit them as a proper patch series.
>
> Thank you for your patience and for guiding a newcomer!
>
> Regards,
> Bohdan
>
> On Wed, Jul 1, 2026 at 11:31 AM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
>>
>> On Tue, Jun 30, 2026 at 7:06 PM Bohdan D. Marcus
>> <bohdandmarcus@xxxxxxxxx> wrote:
>> >
>> > Fix a block comment formatting warning reported by
>> > checkpatch.pl in atomisp_cmd.c to conform to the
>> > Linux kernel coding style.
>>
>> Almost the same comments as per v2. Please, slow down, read other
>> comments and act accordingly.
>>
>> --
>> With Best Regards,
>> Andy Shevchenko