[PATCH v2 0/7] ALSA: Remove redundant open helper return checks
From: phucduc . bui
Date: Thu Jul 02 2026 - 05:14:53 EST
From: bui duc phuc <phucduc.bui@xxxxxxxxx>
Hi all,
This series removes redundant error checks after calls to
nonseekable_open() and stream_open() in the ALSA core.
nonseekable_open() always returns 0, so checking its return value is
unnecessary.
Several users were later converted from nonseekable_open() to
stream_open(), but the original error checks were retained.
Since stream_open() also always returns 0, those checks are likewise
unnecessary.
As a result, all patches simply remove dead error handling paths with no
functional change.
Change in v2 :
- Drop the unnecessary assignment of the return value from
nonseekable_open()/stream_open(), as suggested by Takashi.
- Merge the individual patches into a single patch series.
Best regards,
Phuc
bui duc phuc (7):
ALSA: control: Drop redundant stream_open() return check
ALSA: mixer: oss: Drop redundant nonseekable_open() return check
ALSA: pcm: oss: Drop redundant nonseekable_open() return check
ALSA: pcm: Drop redundant nonseekable_open() return check
ALSA: rawmidi: Drop redundant stream_open() return check
ALSA: seq: Drop redundant stream_open() return check
ALSA: timer: Drop redundant stream_open() return check
sound/core/control.c | 4 +---
sound/core/oss/mixer_oss.c | 4 +---
sound/core/oss/pcm_oss.c | 4 +---
sound/core/pcm_native.c | 14 ++++++++------
sound/core/rawmidi.c | 4 +---
sound/core/seq/seq_clientmgr.c | 5 +----
sound/core/timer.c | 5 +----
7 files changed, 14 insertions(+), 26 deletions(-)
--
2.43.0