Re: [PATCH v2 9/9] mmc: sdhci-cadence: add Altera Agilex5 SD6HC support

[Kathpalia, Tanmay]

Hi Krzysztof,

Thanks for the review.

On 6/29/2026 12:38 PM, Krzysztof Kozlowski wrote:
> On Sat, Jun 27, 2026 at 01:14:54PM -0700, Tanmay Kathpalia wrote:
> > +	rst_combophy = devm_reset_control_get_shared_deasserted(dev, "combophy");
> > +	if (IS_ERR(rst_combophy))
> > +		return dev_err_probe(dev, PTR_ERR(rst_combophy),
> > +				     "failed to get combophy reset\n");
> > +
> > +	/*
> > +	 * Assert SDHCI core and SDMMC OCP/AXI bus resets together so their
> > +	 * active periods overlap before both clock domains are released.
> > +	 */
> > +	rst_sdhc = devm_reset_control_get_exclusive(dev, "sdhc-reset");
> Binding has no reset-names property (just open the binding!), thus you
> cannot use this.

In patch 2 of this series I had added the reset-names property to the
SD6HC binding. Based on your earlier feedback, I'll be splitting the
SD6HC support into a separate binding file in v3, and reset-names
will be defined there accordingly.

>