Re: [PATCH 03/10] net: emac: use DMA-specific and SMP memory barriers

[Paolo Abeni]

On 6/30/26 6:16 AM, Rosen Penev wrote:
> @@ -1845,7 +1845,7 @@ static int emac_poll_rx(void *param, int budget)
>  	}
>  
>  	if (unlikely(budget && test_bit(MAL_COMMAC_RX_STOPPED, &dev->commac.flags))) {
> -		mb();
> +		dma_rmb();
>  		if (!(dev->rx_desc[slot].ctrl & MAL_RX_CTRL_EMPTY)) {
>  			DBG2(dev, "rx restart" NL);
>  			received = 0;

Sashiko geimini thinks the above is not enough for PowerPC:

https://sashiko.dev/#/patchset/20260630041634.284127-1-rosenp%40gmail.com

> diff --git a/drivers/net/ethernet/ibm/emac/zmii.c b/drivers/net/ethernet/ibm/emac/zmii.c
> index a3839cf02ec4..5144ee94a7d2 100644
> --- a/drivers/net/ethernet/ibm/emac/zmii.c
> +++ b/drivers/net/ethernet/ibm/emac/zmii.c
> @@ -258,8 +258,8 @@ static int zmii_probe(struct platform_device *ofdev)
>  	/* Disable all inputs by default */
>  	out_be32(&dev->base->fer, 0);
>  
> -	printk(KERN_INFO "ZMII %pOF initialized\n", ofdev->dev.of_node);
> -	wmb();
> +	dev_info(&ofdev->dev, "ZMII initialized\n");

The printk change is unrelated and should go in a different patch.

/P