Re: [PATCH -next] lockdown: Add break in lockdown_write

From: Nicolas Bouchinet

Date: Fri Jul 03 2026 - 04:25:34 EST


On Thu, Jul 02, 2026 at 12:50:18PM -0400, Paul Moore wrote:
> On Thu, Jan 22, 2026 at 12:41???PM Paul Moore <paul@xxxxxxxxxxxxxx> wrote:
> >
> > On Thu, Jan 22, 2026 at 4:31???AM Xiu Jianfeng <xiujianfeng@xxxxxxxxxx> wrote:
> > > On 1/19/2026 5:12 PM, Cai Xinchen wrote:
> > > > After the label is matched successful, any other levels judgements
> > > > are meaningless. Therefore, add break to return early
> > > >
> > > > Signed-off-by: Cai Xinchen <caixinchen1@xxxxxxxxxx>
> > >
> > > Looks good to me, thanks.
> > >
> > > Acked-by: Xiu Jianfeng <xiujianfeng@xxxxxxxxxx>
> > >
> > > Paul,
> > >
> > > Would you mind if this patch went through the LSM tree? :)
> >
> > Assuming Nicolas is okay with that, I can take this through the LSM tree.
>
> Following up on this as I never saw a response on-list and the patch
> doesn't appear to be in Linus' tree.

Your right, my bad,

First of all, thanks Cai for your contribution and I appologize for the
really late reply.

This is pretty much the same kind of patch as [1], while it effectively
cleans up Lockdown code, in my opinion it doesn't directly add much. I'd
personally prefer to keep those small patches on hold for now, waiting
for a bigger review of Lockdown's code where I will pick them both up.
Sadly, I really don't have much time to work on this right now.

Nicolas

---

[1]: https://lore.kernel.org/all/20260501174448.47154-1-kalevi@xxxxxxxxxxxx/