Re: [PATCH v3 2/3] iio: adc: qcom-spmi-adc5-gen3: Remove an unnecessary print

[Jonathan Cameron]

On Sun, 05 Jul 2026 22:23:34 +0530
Jishnu Prakash <jishnu.prakash@xxxxxxxxxxxxxxxx> wrote:

> devm_request_threaded_irq internally prints an error message using
> dev_err_probe in case of any errors. Remove the error print in the
> devm_request_threaded_irq failure path as it is not needed.
> 
> Signed-off-by: Jishnu Prakash <jishnu.prakash@xxxxxxxxxxxxxxxx>
On basis I might not be taking this through IIO.
Reviewed-by: Jonathan Cameron <jic23@xxxxxxxxxx>

> ---
>  drivers/iio/adc/qcom-spmi-adc5-gen3.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/qcom-spmi-adc5-gen3.c b/drivers/iio/adc/qcom-spmi-adc5-gen3.c
> index c1962312afcd..74988040e6e5 100644
> --- a/drivers/iio/adc/qcom-spmi-adc5-gen3.c
> +++ b/drivers/iio/adc/qcom-spmi-adc5-gen3.c
> @@ -793,9 +793,7 @@ static int adc5_gen3_probe(struct platform_device *pdev)
>  					adc->dev_data.base[ADC5_GEN3_VADC_SDAM].irq_name,
>  					adc);
>  	if (ret)
> -		return dev_err_probe(dev, ret,
> -				     "Failed to request SDAM%d irq\n",
> -				     ADC5_GEN3_VADC_SDAM);
> +		return ret;
>  
>  	ret = adc5_get_fw_data(adc);
>  	if (ret)
>