Re: [PATCH v3 2/3] iio: adc: qcom-spmi-adc5-gen3: Remove an unnecessary print

From: Andy Shevchenko

Date: Mon Jul 06 2026 - 01:46:49 EST


On Sun, Jul 05, 2026 at 10:23:34PM +0530, Jishnu Prakash wrote:
> devm_request_threaded_irq internally prints an error message using

devm_request_threaded_irq()

> dev_err_probe in case of any errors. Remove the error print in the

dev_err_probe()

> devm_request_threaded_irq failure path as it is not needed.
devm_request_threaded_irq()

This patch should go first. The patch 1 is not marked as a fix and we don't
need this message to be printed even before the patch 1 of your current version
of the series.

With that being addressed,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

Also note we refer to the functions as func(), id est mind the parentheses.

--
With Best Regards,
Andy Shevchenko