Re: [PATCH 2/3] arm64: dts: qcom: eliza-evk: Add PCIe1 with TC9563 PCIe switch

[Manivannan Sadhasivam]

On Mon, Jul 06, 2026 at 10:52:27AM +0530, Krishna Chaitanya Chundru wrote:
> 
> 
> On 7/3/2026 8:39 PM, Konrad Dybcio wrote:
> > On 7/3/26 2:38 PM, Krishna Chaitanya Chundru wrote:
> >> The Eliza EVK board connects PCIe1 (8GT/s x2) to a Toshiba TC9563
> >> PCIe switch. Enable PCIe1 and its QMP PHY nodes.
> >>
> >> TC9563 uses I2C (at address 0x77 on I2C4) for its management interface.
> >>
> >> Override the base iommu-map with the expanded set covering all the
> >> switch's downstream ports (0x1400-0x1408 SID range).
> >>
> >> The TC9563 RESX# and PERST# are OR-ed internally to assert reset on the
> >> switch. Use TC9563 RESX# pin via a TLMM GPIO and skip wiring PERST#
> >> from the PCIe controller.
> >>
> >> Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@xxxxxxxxxxxxxxxx>
> >> ---
> > [...]
> >
> >> +&pcie1 {
> >> +	pinctrl-names = "default";
> >> +	pinctrl-0 = <&pcie1_default_state>;
> > flipped order
> >
> > [...]
> >
> >> +&pcie1port0 {
> > This port should also get the compatible
> for pcie1 it is not required, only for m.2 connector we need the compatible.
> 

There is no harm in adding the compatible property, even though it is not
strictly required. As konrad mentioned, if someone creates a board that makes
use of this instance, then we'd need a separate patch for adding the compatible.

Let's make sure we add the compatible for all Root Port nodes in SoC dtsi.

- Mani

-- 
மணிவண்ணன் சதாசிவம்