[PATCH] ALSA: control: preserve snd_card_file_add() error code in snd_ctl_open()
From: phucduc . bui
Date: Tue Jul 07 2026 - 05:16:46 EST
From: bui duc phuc <phucduc.bui@xxxxxxxxx>
snd_ctl_open() unconditionally overwrites the return value of
snd_card_file_add() with -ENODEV on failure, discarding the actual
error code.
This also preserves the original error code returned by
snd_card_file_add() (e.g. -ENOMEM or -ENODEV), instead of
unconditionally overwriting it with -ENODEV.
No functional change other than the returned error code in this
failure path.
Signed-off-by: bui duc phuc <phucduc.bui@xxxxxxxxx>
---
sound/core/control.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/core/control.c b/sound/core/control.c
index 0ca9fff56e51..f64b2dec746a 100644
--- a/sound/core/control.c
+++ b/sound/core/control.c
@@ -64,7 +64,6 @@ static int snd_ctl_open(struct inode *inode, struct file *file)
}
err = snd_card_file_add(card, file);
if (err < 0) {
- err = -ENODEV;
goto __error1;
}
if (!try_module_get(card->module)) {
--
2.43.0