Re: [PATCH] rust: soc: silence clippy warning with rustc >= 1.88
From: Alexandre Courbot
Date: Wed Jul 08 2026 - 06:13:08 EST
On Wed Jul 8, 2026 at 6:04 PM JST, Miguel Ojeda wrote:
> On Wed, Jul 8, 2026 at 10:25 AM Alexandre Courbot <acourbot@xxxxxxxxxx> wrote:
>>
>> Done: https://github.com/rust-lang/rust-clippy/issues/17379
>>
>> As for this patch, I guess we don't need it then?
>
> Thanks a lot for taking the time to fill the issue! Linked to our usual list:
>
> https://github.com/Rust-for-Linux/linux/issues/349
>
> But why do you mean we don't need it? It is still reproducible within
> our possible toolchains, right? Or did I misunderstand something? Or
> do you mean it is fairly rare and thus maybe not needed?
I mean that both the code and clippy setting are properly set, so
using a workaround for this particular occurrence seems like a
half-measure, as the problem can very well arise somewhere else.
>
> We can also always just disable that particular lint, and perhaps
> later on re-enable it conditionally when fixed -- we have support for
> that now.
That sounds like a better way to address this, yes.