Re: [PATCH v3 00/10] sysctl: Consolidate do_proc_* functions into one function

[Joel Granados]

I'll put this into sysctl-next to give us time to test.

On Thu, Jun 25, 2026 at 10:38:12PM +0200, Joel Granados wrote:
> What
> ====
> Generate do_proc_{int,uint,ulong} with the new proc_vec_conv function.
> Removed small differences between each implementation and put it all
> under one roof. This function is meant for internal (to sysctl.c) static
> functions; it should not be used from the outside.
> 
> Groups and document the proc handler and converter functions in
> include/linux/sysctl.h. Document how to create custom converters
> with examples for every converter type.
> 
> This series sits on top of v7.1, you can see the working branch here [1].
> 
> Why
> ===
> Working with one instead of three slightly different implementations of
> the same thing makes more sense to me for three reasons: 1. I don't have
> to think about the different types separately (less context switches),
> 2. One place to begin debugging proc_handler issues and 3. A fix for
> one type, fixes all types.
> 
> Why the intermediate macro
> ==========================
> This series introduces a macro, only to remove it in the last commit.
> I left it like this on purpose because I think the transition to one
> function is made more clear with the intermediate step.
> 
> A word on checkpatch
> ====================
> * It does not like that ENOSYS is returned for the no-op functions. I'm
>   just following the pattern that was initially there. Does -EINVAL
>   makes more sense?
> * It has a false positive on a spacing around a pointer.
> 
> Testing
> =======
> Ran sysctl selftest/kunit on x86_64 and 0-day.
> 
> Changes in v3:
> - Replaced the initial macro implementation with a function.
> - Rebased on top of v7.1
> - Link to v2: https://lore.kernel.org/r/20260101-jag-dovec_consolidate-v2-0-ff918f753ba9@xxxxxxxxxx
> 
> Changes in v2:
> - Handle neg more carefully in the macro:
>   1. Initialize neg to false. So it does not inadvertently return
>      a negative value to user space from an unsigned variable
>   2. Return -EINVAL when the user passes a negative value to an unsigned
>      type.
> - Link to v1: https://lore.kernel.org/r/20251219-jag-dovec_consolidate-v1-0-1413b92c6040@xxxxxxxxxx
> 
> Comments are greatly appreciated
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/joel.granados/linux.git/log/?h=jag/dovec_consolidate
> 
> Signed-off-by: Joel Granados <joel.granados@xxxxxxxxxx>
> ---
> ---
> Joel Granados (10):
>       sysctl: Move default converter assignment out of do_proc_dointvec
>       sysctl: Replace do_proc_dointvec with a type-generic macro
>       sysctl: Generate do_proc_doulongvec_minmax with do_proc_dotypevec macro
>       sysctl: Add negp parameter to douintvec converter functions
>       sysctl: Generate do_proc_douintvec with a type-generic macro
>       sysctl: Rename do_proc_dotypevec macro to do_proc_typevec
>       sysctl: Group proc_handler declarations and document
>       sysctl: Rename proc_doulongvec_minmax_conv to proc_doulongvec_conv
>       sysctl: Update API function documentation
>       sysctl: Replace do_proc_typevec macro with do_proc_vec function
> 
>  fs/pipe.c              |   2 +-
>  include/linux/sysctl.h | 123 +++++++++----
>  kernel/sysctl.c        | 475 ++++++++++++++++++++++++++-----------------------
>  kernel/time/jiffies.c  |  28 ++-
>  4 files changed, 364 insertions(+), 264 deletions(-)
> ---
> base-commit: 8cd9520d35a6c38db6567e97dd93b1f11f185dc6
> change-id: 20251218-jag-dovec_consolidate-5a704f2a3f9b
> 
> Best regards,
> -- 
> Joel Granados <joel.granados@xxxxxxxxxx>
> 
> 

-- 

Joel Granados

Attachment: signature.asc
Description: PGP signature